Improve PR Bot reviewer assignment / pinging#37663
Conversation
|
R: @damccorm |
Summary of ChangesHello @kennknowles, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refines the PR bot's ability to manage reviewer assignments and pings. It addresses previous shortcomings where the bot would incorrectly ping active reviews or fail to recognize reviewers assigned through GitHub's native UI. The changes ensure a more intelligent and less intrusive review process by integrating GitHub's reviewer assignment mechanisms more deeply into the bot's operational logic. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Mildly AI assisted, so feel free to point out areas where I just mis-reviewed the results. |
|
/gemini review |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
Also I don't know how to / how best to test, if it is feasible. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request significantly improves the PR bot's ability to handle reviewer assignments and pings by integrating GitHub UI-assigned reviewers. This addresses key limitations mentioned in the PR description, ensuring that the bot's logic is more comprehensive and accurate. The changes correctly incorporate requested_reviewers into various parts of the workflow, such as excluding them from new assignments, including them in slow review pings, and considering them when determining if a committer needs to be assigned. However, there are a couple of areas that could be further refined to enhance correctness and robustness.
damccorm
left a comment
damccorm
left a comment
There was a problem hiding this comment.
Generally LGTM - thanks for contributing!
Also I don't know how to / how best to test, if it is feasible.
Sadly, the answer is just merge the PR. You can add all of this to a fork and try it there, but it is all one-off testing. Merging and monitoring is usually much easier
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request significantly improves the PR bot's logic for reviewer assignment and pinging. It correctly addresses issues where the bot would ping even when a review was active by refining the comment checking mechanism. Furthermore, it integrates GitHub UI review assignments (requested_reviewers) into the bot's workflow, ensuring they are treated consistently with 'R:' comments for exclusion from new assignments, inclusion in pings, and consideration for committer assignment. The changes enhance the bot's accuracy and responsiveness to various review states.
1. It missed review comments, so would ping even when review was active. 2. It would not treat Github UI review assignments the same as "R:" comments 3. Also now passes a pull request object through various functions, avoiding refetching.
|
Thanks! Merging and will keep an eye on things. |
2 participants
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.